Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argument 1 of Node.appendChild is not an object. #30

Open
lol768 opened this issue Feb 5, 2020 · 0 comments
Open

Argument 1 of Node.appendChild is not an object. #30

lol768 opened this issue Feb 5, 2020 · 0 comments

Comments

@lol768
Copy link

lol768 commented Feb 5, 2020

Look:

rxp-js/dist/rxp-js.js

Lines 221 to 229 in 4fd6948

if (spinner.parentNode) {
spinner.parentNode.removeChild(spinner);
}
closeButton = internal.createCloseButton();
overlayElement.appendChild(closeButton);
closeButton.addEventListener("click", function () {
internal.closeModal(closeButton, iFrame, spinner, overlayElement);
}, true);

Hmm, when can closeButton be undefined?

rxp-js/dist/rxp-js.js

Lines 100 to 103 in 4fd6948

createCloseButton: function (overlayElement) {
if (document.getElementById("rxp-frame-close-" + randomId) !== null) {
return;
}

Maybe every single time after the initial load when the iframe navigates to a URL? Which .. happens every single time the user is 3DS-challenged?

Come on, did you even test this code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant