Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pull request for overall code review of ANAC project 2024 #4313

Closed
wants to merge 643 commits into from
Closed

Pull request for overall code review of ANAC project 2024 #4313

wants to merge 643 commits into from

Conversation

evilaliv3
Copy link
Member

@evilaliv3 evilaliv3 commented Nov 14, 2024 •
edited
Loading

I'm opening this pull request on behalf of @joeman65 for the work they are leading for the Italian National Autority for Anticorruption for year 2024.

This pull request including all the code at once is intended solely to test the overall integration and perform some code review.

Following the project practices the code is expected to be split feature by feature in different branches for proper integration.

\cc @alessiofranceschini

Before submitting a pull request, please ensure the following:

  • The pull request includes a description of the problem you're trying to solve.
  • The pull request provides an overview of the suggested solution.
  • The proposed code is fully functional.
  • The proposed code includes relevant tests to verify its functionality.
  • All new and existing tests pass successfully.
  • Overall code quality and test coverage metrics are not reduced by more than 0.5%

Anna Bellifemine and others added 30 commits October 15, 2024 16:43
questionnaire answers for forwarded tip
a01ce74
Merge branch 'feature/test/segnalazioni' of https://e.bosu:G3JPgbFaRX…
4e2350d 
…[email protected]/servizi-interni/whistleblowing/globaleaks.git
progress in form for forwarded dip (oe)
ea6abc1
Update submission.py
d10c6b6
Update __init__.py and submission.py
4250436
date tipe in oe form
3360641
clean code and bugfixing
723ce2b
form for forwarded tip - type tos
84476d2
Update __init__.py
69038b2
Update requests.py
d68464d
Merge branch 'feature/test/segnalazioni' of https://e.bosu:G3JPgbFaRX…
95d2792 
…[email protected]/servizi-interni/whistleblowing/globaleaks.git
Backup's implementation
2abde61
Update __init__.py and __init__.py
c77e0ad
Merge branch 'feature/test/segnalazioni' of https://e.bosu:G3JPgbFaRX…
9f09b31 
…[email protected]/servizi-interni/whistleblowing/globaleaks.git
forwarder report closing integration
3d3f960
bugfixing
f37e0a8
REF: Implement changes necessary to load a secret and use it as secre…
e66f661 
…t for decrypting reports
Merge branch 'feature/test/segnalazioni' of https://e.bosu:G3JPgbFaRX…
120ff4b 
…[email protected]/servizi-interni/whistleblowing/globaleaks.git

#Conflicts:
#	backend/globaleaks/handlers/auth/__init__.py
Update __init__.py, submission.py, and 2 more files...
e3a6884
bugfixing
fc5ebeb
Update __init__.py
f326957
Merge branch 'feature/test/segnalazioni' of https://e.bosu:G3JPgbFaRX…
2e5237c 
…[email protected]/servizi-interni/whistleblowing/globaleaks.git
REF: Implement changes necessary to load a secret and use it as secre…
587fb48 
…t for decrypting reports
closing fowarding bugfixing
f249c6b
Update accreditation.py and wizard.py
338716b
bugfixing sendtip-detail
cae0aa5
download permission for infected files in forwarding detail
0a90c78
fix reset comments and files for selected oe
4abd7bc
clean code and bugfixing on upload-wbfile-component
97ece45
fix affiliated oe + clean code
7022e60
Alessio Franceschini and others added 25 commits November 13, 2024 09:41
Updated .github
90c93ea
Updated test db
72110d1
Fix label on report and format date
81b0c24
Update globaleaks-69.db and helpers.py
34b693b
Update user.py, test_user.py, and helpers.py
b99f2e4
Update helpers.py
044a5e8
Update helpers.py
0d8b773
Added audit log on whistleblower download file
e825c1c
Update globaleaks-69.db
56e81fc
Update rtip.py
c27a529
Merge branch 'devel' of https://e.bosu:[email protected]…
2e6112f 
…ticorruzione.it/servizi-interni/whistleblowing/globaleaks.git
preference resolver for accreditor
288be68
Merge branch 'devel' of https://gitlab.anticorruzione.it/servizi-inte…
bb24cb2 
…rni/whistleblowing/globaleaks into devel
Update test_api.py
3f27284
Update test_rtip.py
8393ef8
Fix disabled fiscal code on invited EO accreditation
aca1778
Update rtip.py and wbtip.py
19632c9
Update test_rfile.py
9913112
fix for maximum number of fields
d7febf6
Update test_rfile.py
51d2d59
Merge branch 'devel' of https://e.bosu:[email protected]…
3d703a8 
…ticorruzione.it/servizi-interni/whistleblowing/globaleaks.git
cypress - configure user test
c525907
cypress - add new accreditor
27ee7f1
cypress - users login
700dba0
Update rtip.py
1eaa3b9
@evilaliv3 evilaliv3 requested a review from a team as a code owner November 14, 2024 14:59
@evilaliv3 evilaliv3 changed the base branch from devel to tenant-optimization November 14, 2024 15:56
@evilaliv3 evilaliv3 changed the base branch from tenant-optimization to devel November 14, 2024 15:57
@evilaliv3
Copy link
Member Author

Closing and re-opening the pull request after modifying code to run tests properly.

@evilaliv3 evilaliv3 closed this Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@evilaliv3