Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extention of the signup module to handle accreditation process #4328

Open
evilaliv3 opened this issue Nov 21, 2024 · 1 comment
Open

Extention of the signup module to handle accreditation process #4328

evilaliv3 opened this issue Nov 21, 2024 · 1 comment

Comments

@evilaliv3
Copy link
Member

evilaliv3 commented Nov 21, 2024

This ticket is related to the analysis and integration of the accreditation feature included in #4314 as an extension a the existing signup module

The new feature is expected to enable an organization request a platform that differently from the DEMO mode will be enabled manually by a dedicated set of users for which a new Accreditor user role will be designed.

@evilaliv3
Copy link
Member Author

evilaliv3 commented Nov 21, 2024

Status of the current implementation:

  • The functionality seems to be implemented without using the existing signup module with significant duplication of its functionality; it seems as well not possible to enable or disable the feature that automatically replaces existing software interfaces impacting other software functionalities.
  • The implementation seems to not the specifications provided to abstract the configuration of the italian certified mail system (PEC) the more simple naming SMTP2

Actions necessary to possibly integrate same functionality:

  • Re-implement the functionality on the base of the signup module the signup module as a new "mode" alternative to the current DEMO, WHISTLEBLOWING modes) automatically inheriting the functionalities of enabling/disabling the feature and intheriting all the unit tests
  • To not impact other It should be added an enabler for the secondary SMTP2 server to be used for accreditation only if enabled so to not impact existing users for which the secondary SMTP2 configuration should be configured disabled by default
  • Writing the tests to cover the specific new functionalities added on top of the existing signup module.

evilaliv3 added a commit that referenced this issue Nov 23, 2024
Changes:
- replace 'is_pec' variable with 'use_secondary_smtp' to perform international abstraction of 'pec' using just the concept of smtp
- replace 'fiscal_code' variables 'tax_code' convention used in the software as international level
- remove 'sharing_id' addition redundant considering existing subscriber.tid equals tenant.id as unique reference
- add 'smtp2_enabled' to make it possible to enable/disable the smtp2 configuration
- add missing variables recipient_* on signup table planned to host name for a subscriber
- uniform variables for subscriber user (used to instantiate the admin) and the new recipient variables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant