test case optimizations

File Upload Completion Checks: Ensured files are fully uploaded before further processing. Homepage Header Title Fix: Resolved ID fetch issue.
globaleaks · Nov 14, 2024 · d14f2c9 · d14f2c9
1 parent 6f9dbe4
commit d14f2c9
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/client/app/src/pages/admin/settings/tab1/tab1.component.html b/client/app/src/pages/admin/settings/tab1/tab1.component.html
@@ -17,7 +17,7 @@
     <div class="form-group">
       <label>{{ 'Homepage title' | translate }}</label>
       <div>
-        <textarea class="form-control" name="node.dataModel.header_title_homepage" [(ngModel)]="nodeResolver.dataModel.header_title_homepage"></textarea>
+        <textarea class="form-control" name="node.dataModel.header_title_homepage" [attr.data-cy]="'header_title_homepage'" [(ngModel)]="nodeResolver.dataModel.header_title_homepage"></textarea>
       </div>
     </div>
     <div class="form-group">

diff --git a/client/cypress/e2e/11-test-admin-configure-languages.cy.ts b/client/cypress/e2e/11-test-admin-configure-languages.cy.ts
@@ -30,7 +30,7 @@ describe("admin configure languages", () => {
 
     cy.waitForUrl("/#/admin/settings");
     cy.get('#LanguagePickerBox').should('be.visible').find('ng-select').last().click().get('ng-dropdown-panel').contains('Italiano').click();
-    cy.get('[name="node.dataModel.header_title_homepage"]').clear().type("TEXT1_IT");
+    cy.get('[data-cy="header_title_homepage"]').clear().type("TEXT1_IT");
     cy.get('[name="node.dataModel.presentation"]').clear().type("TEXT2_IT");
     cy.get('button.btn.btn-primary').eq(0).get("#save_settings").click();
 
@@ -60,7 +60,8 @@ describe("admin configure languages", () => {
     cy.visit("/#/admin/settings");
     cy.waitForUrl("/#/admin/settings");
     cy.get('#LanguagePickerBox').should('be.visible', { timeout: 10000 }).find('ng-select').last().click().get('ng-dropdown-panel').contains('Italian').click();
-    cy.get('[name="node.dataModel.header_title_homepage"]').clear();
+    cy.get('[data-cy="header_title_homepage"]').clear();
+
     cy.get('[name="node.dataModel.presentation"]').clear();
     cy.get('button.btn.btn-primary').eq(0).get("#save_settings").click();
 

diff --git a/client/cypress/e2e/15-test-admin-configure-network.cy.ts b/client/cypress/e2e/15-test-admin-configure-network.cy.ts
@@ -30,18 +30,21 @@ describe("admin configure network", () => {
       fileName: "key.pem",
       mimeType: "application/x-pem-file"
     }, {"force": true});
+    cy.get("#deleteKey").should('be.visible')
 
     cy.get("div.card.cert input[type=file]").selectFile({
       contents: "../backend/globaleaks/tests/data/https/valid/cert.pem",
       fileName: "cert.pem",
       mimeType: "application/x-pem-file"
     }, {"force": true});
+    cy.get("#deleteCert").should('be.visible')
 
     cy.get("div.card.chain input[type=file]").selectFile({
       contents: "../backend/globaleaks/tests/data/https/valid/chain.pem",
       fileName: "chain.pem"
     }, {"force": true});
 
+    cy.get("#deleteChain").should('be.visible')
     cy.get("#deleteChain").click();
     cy.get("#modal-action-ok").click();