You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When you are in current state of repo and comment on top level dir (home page of project show) comments will be associated with project. If you go a level deeper and comment inside a dir then the comment will be associated with tree of repo.
Again if you go to commit view and click on browse files at this commit, and decide to comment, both top level comments and comments deeper in repo gets associated with tree.
I think this is ambiguous. Comments on top level dir should always be associated with tree. I am not saying that this will change user expereince. If user decides to think of top level comments as comments on project then so be it. I am just proposing that internally we shouldn't have distinction between top dir comment and internal ones.
The text was updated successfully, but these errors were encountered:
I am sorry. I was wrong about this not affecting users. I still think that top level comments should be associated with tree and not project. If there has to be a thing like project comments then we should find a different place for it. (May be just another tab in toolbar)
Hi @sonalkr132 I'm sorry I couldn't quite follow what you're trying to suggest. From a flow perspective, one needs to be able to comment on albums on the whole, as well on individual images that belong to those albums.
When you are in current state of repo and comment on top level dir (home page of project show) comments will be associated with project. If you go a level deeper and comment inside a dir then the comment will be associated with tree of repo.
Again if you go to commit view and click on
browse files at this commit
, and decide to comment, both top level comments and comments deeper in repo gets associated with tree.I think this is ambiguous. Comments on top level dir should always be associated with tree.
I am not saying that this will change user expereince. If user decides to think of top level comments as comments on project then so be it. I am just proposing that internally we shouldn't have distinction between top dir comment and internal ones.The text was updated successfully, but these errors were encountered: