Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tree comment association with project #316

Open
sonalkr132 opened this issue Oct 27, 2015 · 2 comments
Open

Tree comment association with project #316

sonalkr132 opened this issue Oct 27, 2015 · 2 comments

Comments

@sonalkr132
Copy link
Collaborator

When you are in current state of repo and comment on top level dir (home page of project show) comments will be associated with project. If you go a level deeper and comment inside a dir then the comment will be associated with tree of repo.
Again if you go to commit view and click on browse files at this commit, and decide to comment, both top level comments and comments deeper in repo gets associated with tree.

I think this is ambiguous. Comments on top level dir should always be associated with tree.
I am not saying that this will change user expereince. If user decides to think of top level comments as comments on project then so be it. I am just proposing that internally we shouldn't have distinction between top dir comment and internal ones.

@sonalkr132
Copy link
Collaborator Author

I am sorry. I was wrong about this not affecting users. I still think that top level comments should be associated with tree and not project. If there has to be a thing like project comments then we should find a different place for it. (May be just another tab in toolbar)

@sarupbanskota
Copy link
Contributor

Hi @sonalkr132 I'm sorry I couldn't quite follow what you're trying to suggest. From a flow perspective, one needs to be able to comment on albums on the whole, as well on individual images that belong to those albums.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants