user's page and follow

[sonalkr132]

Way we handling follow isn't great yet. Right now, if you click follow on your own profile, it would do nothing.. it would just render everything again (please ignore my demo). Previously it would redirect to dashboard but @Alwahsh added a test which requires for user to stay on same page and I think it makes sense. User should stay on same page if he is already logged on, what we should do is flash a message to him that he can't follow himself or something like? May be we can disable the link follow if he is on his own profile? We do need to implement flashing notice design at some point, and current design doesn't seem to have space for it.. if we flash a notice under nav bar, everything would move down with a jerk.

Suggestions?

[rohitpaulk]

We do need to implement flashing notice design at some point, and current design doesn't seem to have space for it.. if we flash a notice under nav bar, everything would move down with a jerk.

I don't think that's very bad UX, quite common in fact. I'd recommend doing the backend work and getting the flash notice there first - we can worry about small UI nuances later.

[Alwahsh]

I've actually noticed that the rendering of flash messages is not put in the layout... It is put in the shared/messages which IMO is not a good practice. I was planning to move it to the layout but never got to it :). If we do that, all flashes would appear(following is not the only flash message that you don't see).

For the follow button, I remember that it is doing its request using AJAX. We thus need to add a javascript file that would be used as a reply to a failing AJAX request. That file should modify the flash part to show the error.

[mecyborg]

Flash messages is a good idea, We should do this.
And what about linking profiles of followed/following users ?

[sonalkr132]

Looks awful! Or may be I am really bad at designs 😁

Adding notice to backend is easy.. one just needs to add notice:

[Alwahsh]

I think that would look good when coded ;)

[mecyborg]

We can show alerts at right bottom corner !

[sonalkr132]

or may be bottom left like fb ;)