Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Fix service worker #29

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

WIP: Fix service worker #29

wants to merge 5 commits into from

Conversation

marcoow
Copy link
Member

@marcoow marcoow commented Nov 8, 2017

This is a WIP for fixing the service worker by:

  • enabling asset fingerprinting (basically as part of upgrading to the latest blueprint)
  • enabling the service worker again
  • updating the cache for successful doc requests so we're serving the latest version from the service worker when the user is offline

The only problem I see is that eagerly caching the assets doesn't work because we're not replacing the asset names in workers/service.ts as part of the build process (yet) and I'm not sure what the best way to do that is. So currently the service worker would cache e.g. app.js on installation but the browser will ask for app-hash.js later.

closes #28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the service worker
1 participant