Allow overriding ctrl-w using a webextension command

[tbodt]

https://developer.chrome.com/extensions/commands

If you create a command, then go to the extension keyboard shortcut settings and map ctrl-w to it, that will override the close tab shortcut. This may also work with firefox.

[glacambre]

Hi, thanks for pointing this out, I had completely forgotten about the commands API. This API doesn't let you override what happens when you press <C-w> on Firefox, which was the only browser I supported when I wrote the Drawbacks section of the readme.
I'll see what I can do for Chrome :).

[NilsIrl]

According to the description of this addon, this might only be the case on Linux.

Related bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1325692

[glacambre]

I've implemented the ability to override <C-n>, <C-t> and <C-w> (which are the only 3 keyboard shortcuts that can't be overriden on Chrome AFAIK) in 8c73600, read this to discover how to use it :).
Note that this is currently only available if you build the browser extensions from source - otherwise you'll have to wait for me to publish a new release.

[Freed-Wu]

Thanks!

[glacambre]

Hi :).

I've seen your guide here https://github.com/glacambre/firenvim#drawbacks but don't understand how to use it. The patch here https://github.com/glacambre/firefox-patches does not have any instructions.

This is a firefox patch, you need to apply it to Firefox's source code and then recompile Firefox. If you don't want to recompile Firefox, instructions to patch a compiled Firefox have been described here: glacambre/firefox-patches#1

Is it possible to pass c-w mapping to firenvim when the frame is focused? This would be preferred. Or at least intercept the browser default behavior to close the tab so I would not loose my work? Or maybe at least prompt for closing the tab like those annoying confirmation dialogs some websites uses before leaving the iste?

This is not possible without patching Firefox. This is something Mozilla does on purpose. If you want this to change, you'll need to convince them on bugzilla.mozilla.org, but know that a lot of people have tried to do that over the years and that none succeeded :/.

[glacambre]

Yes, you can narrow the replacement by using key id="key_close" data-l10n-id="close-shortcut" command="cmd_close" modifiers="accel" reserved="true" as the pattern and key id="key_close" data-l10n-id="close-shortcut" command="cmd_close" modifiers="accel" as the replacement :)

[glacambre]

But shouldn't the regex be like this (the spaces replacing the reserved attribute)?

Yeah, probably :)