Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates Launchpad search UX to avoid always searching with the API #3856

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Updates Launchpad search UX to avoid always searching with the API #3856

wants to merge 3 commits into from
+148 −42

Conversation

axosoft-ramint
Copy link
Contributor

@axosoft-ramint axosoft-ramint commented Dec 10, 2024 •
edited
Loading

Closes #3855

Current approach has some hacky workarounds to accommodate:

  • Directly moving into search mode when a PR url is pasted in
  • Not losing the content of the search box when toggling search mode on
  • Showing the option to toggle search mode on if no results are found when searching with it off

Suggestions welcome

@axosoft-ramint axosoft-ramint added feature New feature or request area-launchpad Issues or features related to Launchpad labels Dec 10, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 10, 2024
View reviewed changes
src/plus/launchpad/launchpad.ts Fixed Show resolved Hide resolved
src/plus/launchpad/launchpad.ts Fixed Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamodio eamodio Awaiting requested review from eamodio

Assignees

@eamodio eamodio

Labels
area-launchpad Issues or features related to Launchpad feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Launchpad PR search refinement
2 participants
@axosoft-ramint @eamodio