Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Rebase interface partially unreadable in high contrast dark color theme #3646

Closed
sparr opened this issue Oct 7, 2024 · 4 comments · Fixed by #3724 or #3737
Closed

Interactive Rebase interface partially unreadable in high contrast dark color theme #3646

sparr opened this issue Oct 7, 2024 · 4 comments · Fixed by #3724 or #3737
Assignees
@nzaytsev
Labels
verified ✔ Verified
Milestone
16.0

Comments

@sparr
Copy link

sparr commented Oct 7, 2024

Description

My theme settings are dark and high contrast and I cannot read the dropdown or main button in the attached screenshot.

GitLens Version

15.5.1

VS Code Version

Version: 1.93.1
Release: 24256
Commit: dbab3f8e8c5da7ca1bde636806e0a973e497aa01
Date: 2024-09-18T01:06:54.725Z
Electron: 30.4.0
ElectronBuildId: undefined
Chromium: 124.0.6367.243
Node.js: 20.15.1
V8: 12.4.254.20-electron.0
OS: Linux x64 6.10.10-arch1-1

Git Version

2.46.2

Logs, Screenshots, Screen Captures, etc

Image
@sparr sparr added bug triage Needs to be looked at labels Oct 7, 2024
@nzaytsev nzaytsev self-assigned this Nov 8, 2024
@nzaytsev nzaytsev linked a pull request Nov 8, 2024 that will close this issue
Fixes invisible dropdown in the rebase view #3724
Merged
7 tasks
@d13 d13 closed this as completed in #3724 Nov 8, 2024
@d13 d13 added this to the 16.0 milestone Nov 8, 2024
@d13 d13 added needs-verification Request for verification pending-release Resolved but not yet released to the stable edition and removed triage Needs to be looked at labels Nov 8, 2024
@d13 d13 reopened this Nov 12, 2024
@d13
Copy link
Member

d13 commented Nov 12, 2024

@nzaytsev - Dropdown colors are fixed, but button text labels still appear unstyled on high-contrast themes. Essentially, anywhere we have CSS selectors for vscode-light and vscode-dark classes we also need to include vscode-high-contrast-light and vscode-high-contrast respectively.

@d13 d13 mentioned this issue Nov 12, 2024
Closed
@nzaytsev nzaytsev linked a pull request Nov 13, 2024 that will close this issue
Improves theme following on webviews #3737
Merged
7 tasks
@d13 d13 closed this as completed in #3737 Nov 13, 2024
@sergeibbb sergeibbb self-assigned this Nov 14, 2024
@sergeibbb sergeibbb added the verified ✔ Verified label Nov 14, 2024
@sergeibbb
Copy link
Member

I'm a bad verifier for this, because on my machine VS Code uses system pop-up. It's better someone else to check it:

Image

@sergeibbb sergeibbb removed the verified ✔ Verified label Nov 14, 2024
@sergeibbb sergeibbb removed their assignment Nov 14, 2024
@axosoft-ramint
Copy link
Contributor

Seems to work in current pre-release

Image

@axosoft-ramint axosoft-ramint added verified ✔ Verified and removed needs-verification Request for verification pending-release Resolved but not yet released to the stable edition labels Nov 14, 2024
@github-actions GitHub Actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2024
@d13 d13 removed the bug label Feb 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nzaytsev nzaytsev

Labels
verified ✔ Verified
Projects
None yet
Milestone
16.0
5 participants
@sparr @d13 @axosoft-ramint @sergeibbb @nzaytsev