Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change branch terminal-run commands into normal commands w/ proper error handling #3528

Open
1 task
Tracked by #3527
eamodio opened this issue Sep 6, 2024 · 1 comment · Fixed by #3596 · May be fixed by #3597
Open
1 task
Tracked by #3527

Change branch terminal-run commands into normal commands w/ proper error handling #3528

eamodio opened this issue Sep 6, 2024 · 1 comment · Fixed by #3596 · May be fixed by #3597
Assignees
@sergiolms
Labels
debt Technical debt feature New feature or request
Milestone
16.0

Comments

@eamodio
Copy link
Member

eamodio commented Sep 6, 2024 •
edited
Loading

Refs: #3527

We may also want to consider #1828 when converting branch delete

Identify all the cases and create issues to track each one

Tasks
Beta Give feedback
@eamodio eamodio mentioned this issue Sep 6, 2024
Open
@eamodio eamodio added this to the 15.5 milestone Sep 6, 2024
@eamodio eamodio added debt Technical debt feature New feature or request labels Sep 6, 2024
@eamodio eamodio changed the title Change terminal-run branch commands into normal commands w/ proper error handling Change branch terminal-run commands into normal commands w/ proper error handling Sep 6, 2024
@eamodio eamodio changed the title Change branch terminal-run commands into normal commands w/ proper error handling Change branch terminal-run commands into normal commands w/ proper error handling Sep 6, 2024
@sergiolms sergiolms mentioned this issue Sep 20, 2024
Merged
7 tasks
@sergiolms
Copy link
Contributor

Part 1: #3596

@sergiolms sergiolms linked a pull request Sep 20, 2024 that will close this issue
Change branch create and branch rename into normal commands #3596
Merged
7 tasks
@sergiolms sergiolms linked a pull request Sep 20, 2024 that will close this issue
Open
7 tasks
eamodio added a commit that referenced this issue Sep 26, 2024
@eamodio
Refactors branch creation and renaming
09b08cb 
 - Moves error handling outside of GitProviderService (to allow callers control over handling)
- Splits unified branch command into specific calls and makes them optional

Refs #3528
sergiolms pushed a commit that referenced this issue Sep 27, 2024
@eamodio @sergiolms
Refactors branch creation and renaming
aae8254 
 - Moves error handling outside of GitProviderService (to allow callers control over handling)
- Splits unified branch command into specific calls and makes them optional

Refs #3528
@eamodio eamodio modified the milestones: 16.0, 15.6 Sep 27, 2024
eamodio added a commit that referenced this issue Sep 27, 2024
@eamodio
Refactors branch creation and renaming
28e7774 
 - Moves error handling outside of GitProviderService (to allow callers control over handling)
- Splits unified branch command into specific calls and makes them optional

Refs #3528
@eamodio eamodio reopened this Sep 27, 2024
@axosoft-ramint axosoft-ramint modified the milestones: 15.6, 16.0 Oct 2, 2024
sergiolms added a commit that referenced this issue Oct 4, 2024
@sergiolms
Merge branch 'feature/#3528-part2_change_branch_into_normal_cmd' of g…
4794ca0 
…ithub.com:gitkraken/vscode-gitlens into feature/#3528-part2_change_branch_into_normal_cmd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergiolms sergiolms

Labels
debt Technical debt feature New feature or request
Projects
None yet
Milestone
16.0
3 participants
@eamodio @axosoft-ramint @sergiolms