Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running tests can try to run non-tests as tests #1480

Open
alexet opened this issue Aug 26, 2022 · 0 comments
Open

Running tests can try to run non-tests as tests #1480

alexet opened this issue Aug 26, 2022 · 0 comments
Labels
bug Something isn't working VSCode

Comments

@alexet
Copy link
Contributor

alexet commented Aug 26, 2022

Describe the bug
When you have a folder that contains both multiple test packs and non-test packs, it will appear as runnable in the UI with the test packs a subpacks. When you run that folder it will also run the non-tests ibnside it as well.

Version
CodeQL extension version: 1.6.11
CodeQL CLI version: 2.10.3
Platform: linux x64

To reproduce
Open https://github.com/github/codeql-coding-standards/tree/next
Run the c folder in the testing pane. See codeql fail to find the extractor for a non-test folder.

Expected behavior

Only to try run the tests as tests.

Additional context

This can be seen by trying to run the c folder on https://github.com/github/codeql-coding-standards/tree/next

I think we either need to pass --strict-test-discovery when running or explicitly pass the set of tests rather than the folder.

@alexet alexet added the bug Something isn't working label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working VSCode
Projects
None yet
Development

No branches or pull requests

1 participant