Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: assign collaborators #45

Closed
wants to merge 1 commit into from
Closed

feat: assign collaborators #45

wants to merge 1 commit into from

Conversation

afonsojramos
Copy link

@afonsojramos afonsojramos commented May 19, 2022 •
edited
Loading

Fixes #44. Since you were not handling non-existing labels I decided to use the same approach for assignees.

Also removed the function getLabels since it was not being used.

Note: How are you building the file under lib? We should automate it no?

@afonsojramos
Copy link
Author

@stephanmiehe created the PR if you could review 😄

I chose not to change the yml structure so it either be a label or an assignee.

stephanmiehe
stephanmiehe requested changes Jun 4, 2022
View reviewed changes
Copy link
Collaborator

@stephanmiehe stephanmiehe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution We'll want to respect assignees and labels separately. Without it the moment someone has a username that matches a label it's going to create challenges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanmiehe stephanmiehe stephanmiehe requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Assign repository collaborators based on regex
2 participants
@afonsojramos @stephanmiehe