-
Notifications
You must be signed in to change notification settings - Fork 82
-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ado2gh] RewirePipeline - Accept definitionId (int) for ado-pipeline parameter #1222
Comments
@tiago-soczek I would suggest creating a new option |
It also works, using two options it will be necessary to change the validation ( |
Yeah that validation would live here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently, we provide the name or path of the pipeline definition (ado-pipeline) to perform the rewire.
With this value, we look for the definitionId (int) - this is expensive as it is necessary to enumerate all Definitions as the API does not provide a method for this.
To avoid this, the user could have the option to directly pass definitionId - this would avoid unnecessary calls and make the process faster.
The suggestion is to use the same parameter (ado-pipeline) and in the implementation, consider that it is the definitionId if it is a number, otherwise, follow the current process - convenient for those who do not have the definitionId at hand.
It makes sense? If so, I will provide a PR.
The text was updated successfully, but these errors were encountered: