Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency ecosystems not correctly detected #29

Open
martincostello opened this issue Jan 27, 2024 · 2 comments
Open

Dependency ecosystems not correctly detected #29

martincostello opened this issue Jan 27, 2024 · 2 comments
Labels
bug Something isn't working keep do not mark as stale ready-for-work Issue is defined enough to begin implementation

Comments

@martincostello
Copy link
Contributor

The logic to detect whether to configure package updates for most ecosystems, except for GitHub Actions and Terraform only appears to consider files in the root of the repository.

I found this after testing the action out on a .NET repository where the .csproj files are in subdirectories within the repository. The action generated a dependabot.yml file that only specified GitHub Actions updates.

Each file tested for should recurse through the repository to try and files (maybe within a configurable depth limit to reduce impact on rate limits) so that the generated file is a more accurate reflection of what should be configured.

@zkoppert zkoppert added bug Something isn't working ready-for-work Issue is defined enough to begin implementation labels Jan 29, 2024
Copy link

This issue is stale because it has been open 21 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the Stale label Mar 13, 2024
@zkoppert zkoppert added keep do not mark as stale and removed Stale labels Mar 14, 2024
@zkoppert
Copy link
Member

For this maybe its better to temporarily clone the repository and do file search for project files? I feel like rate limits would be spent quickly otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working keep do not mark as stale ready-for-work Issue is defined enough to begin implementation
Projects
None yet
Development

No branches or pull requests

2 participants