Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the aria attribute for octicons with text #35376

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Unify the aria attribute for octicons with text #35376

merged 2 commits into from
Nov 21, 2024
+44 −44

Conversation

akordowski
Copy link
Contributor

Why:

As discussed in #35326 this PR unifies the aria attribute for octicons with text, by replacing aria-label="..." with aria-hidden="true".

Closes: #35326

What's being changed (if available, include any code snippets, screenshots, or gifs):

Replace aria-label with aria-hidden for octoicons with precedent or subsequent text

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.

  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
actions/managing-workflow-runs-and-deployments/managing-deployments/managing-environments-for-deployment.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
apps/using-github-apps/reviewing-and-modifying-installed-github-apps.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
code-security/code-scanning/creating-an-advanced-setup-for-code-scanning/customizing-your-advanced-setup-for-code-scanning.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
code-security/code-scanning/managing-code-scanning-alerts/resolving-code-scanning-alerts.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
code-security/code-scanning/troubleshooting-code-scanning/default-setup-fails-with-a-language.md ghes@ 3.11 3.10
ghes@ 3.11 3.10
code-security/getting-started/quickstart-for-securing-your-repository.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
code-security/secret-scanning/using-advanced-secret-scanning-and-push-protection-features/custom-patterns/defining-custom-patterns-for-secret-scanning.md ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
code-security/security-overview/filtering-alerts-in-security-overview.md ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
copilot/managing-copilot/managing-github-copilot-in-your-organization/managing-access-to-github-copilot-in-your-organization/managing-requests-for-copilot-business-in-your-organization.md fpt
ghec
 fpt
ghec
copilot/using-github-copilot/asking-github-copilot-questions-in-your-ide.md fpt
ghec
 fpt
ghec
desktop/working-with-your-remote-repository-on-github-or-github-enterprise/viewing-a-pull-request-in-github-desktop.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
education/contribute-with-github-community-exchange/getting-started-with-github-community-exchange.md fpt
 fpt
issues/organizing-your-work-with-project-boards/tracking-work-with-project-boards/adding-issues-and-pull-requests-to-a-project-board.md ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
issues/planning-and-tracking-with-projects/managing-your-project/managing-project-templates-in-your-organization.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
organizations/managing-organization-settings/disabling-project-boards-in-your-organization.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
repositories/configuring-branches-and-merges-in-your-repository/managing-branches-in-your-repository/renaming-a-branch.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
repositories/working-with-files/using-files/downloading-source-code-archives.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
repositories/working-with-files/using-files/navigating-code-on-github.md fpt
ghec
 fpt
ghec
sponsors/getting-started-with-github-sponsors/navigating-your-sponsors-dashboard.md fpt
ghec
 fpt
ghec
sponsors/sponsoring-open-source-contributors/paying-for-github-sponsors-by-invoice.md fpt
ghec
 fpt
ghec
actions/using-github-hosted-runners/using-larger-runners/managing-larger-runners.md fpt
ghec
 fpt
ghec
 from reusable
actions/using-github-hosted-runners/using-github-hosted-runners/monitoring-your-current-jobs.md fpt
ghec
 fpt
ghec
 from reusable
actions/hosting-your-own-runners/managing-self-hosted-runners/managing-access-to-self-hosted-runners-using-groups.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/using-github-hosted-runners/using-larger-runners/controlling-access-to-larger-runners.md fpt
ghec
 fpt
ghec
 from reusable
actions/hosting-your-own-runners/managing-self-hosted-runners/monitoring-and-troubleshooting-self-hosted-runners.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
actions/hosting-your-own-runners/managing-self-hosted-runners/using-labels-with-self-hosted-runners.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
code-security/secret-scanning/copilot-secret-scanning/generating-regular-expressions-for-custom-patterns-with-copilot-secret-scanning.md ghec
 ghec
 from reusable
admin/managing-accounts-and-repositories/communicating-information-to-users-in-your-enterprise/customizing-user-messages-for-your-enterprise.md ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
admin/managing-accounts-and-repositories/managing-users-in-your-enterprise/suspending-and-unsuspending-users.md ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
from reusable
code-security/secret-scanning/using-advanced-secret-scanning-and-push-protection-features/excluding-folders-and-files-from-secret-scanning.md fpt
ghec
ghes@ 3.15 3.14 3.13 3.12 3.11 3.10
fpt
[ghec](https://docs.github.com/en...*[Comment body truncated]*

nguyenalex836
nguyenalex836 previously approved these changes Nov 21, 2024
View reviewed changes
@nguyenalex836
Copy link
Contributor

@akordowski Thanks so much for opening a PR with these fixes! I'll update the branch and get this merged once tests are passing 🍏

@nguyenalex836 nguyenalex836 added this pull request to the merge queue Nov 21, 2024
Merged via the queue into github:main with commit 6ec89f2 Nov 21, 2024
45 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenalex836 nguyenalex836 nguyenalex836 approved these changes

Assignees
No one assigned
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent formatting of text with octicons
2 participants
@akordowski @nguyenalex836