-
Notifications
You must be signed in to change notification settings - Fork 59.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify the existing pending job is canceled #34657
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
@zachborboacryptofi Thank you for opening a PR! ✨ Can you elaborate on what you are hoping to clarify by adding the word "existing" to the reusable? 💛 |
@nguyenalex836 Hi. I think adding "existing" to the pending job will help clarify the documentation, as the current wording can be a bit confusing. The update emphasizes that we're referring to any pending job or workflow that's already in place that will be canceled and not the new incoming pending job or workflow, which should make it clearer for readers. As currently written, it reads like this:
By emphasizing that the existing pending job, if it exists, is canceled, it reads like this:
|
@zachborboacryptofi Thank you for the elaboration! I'll triage this for review so that we can get a writer to weigh in on this change as well 💛 |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
@zachborboacryptofi Thank you for those final updates! We'll get this merged 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
Docs clarification.
Closes: N/A
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.