A13-3-1: Query reports about function overloads at the same location.
#796
Labels
false positive/false negative
An issue related to observed false positives or false negatives.
Standard-AUTOSAR
Comments
rak3-sh
added
the
false positive/false negative
Possible FixWhile we can try and understand in greater detail why CodeQL returns two overloaded functions in the same location but at least for this query, it will be pragmatic to check for the difference in location explicitly in the query and removes such unwanted results in FunctionThatContainsForwardingReferenceAsItsArgumentOverloaded.ql, from
Candidate c, Function f, Function overload, Function overloaded, string msg,
string firstMsgSegment
where
<... snip ...>
f = c.getAnOverload() and
<...snip...>
// -- Fix start - check location is different
f.getLocation() != c.getLocation()
// -- Fix end
<snip> ...
overloaded = c and
overload = f
select overload, "Function" + firstMsgSegment + "overloads a $@.", overloaded, msg |
Open
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affected rules
Description
This query reports two overloaded functions but at the same location in the code base, thereby causing confusion to the user. It may be good to check the location explicitly to avoid such a case. Please note that the implementation already checks if the overloaded function and the candidate function are not the same and also they are not Function Template Instantiation or Specialization. Still, the query results in the same function to be reported as the candidate as well as the overloaded function.
Example
Not able to minimize the problem
The text was updated successfully, but these errors were encountered: