Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor]: Lambda Control plane - introduce service (proxy) layer for GitHub API calls #4365

Open
npalm opened this issue Jan 17, 2025 · 0 comments
Open

[refactor]: Lambda Control plane - introduce service (proxy) layer for GitHub API calls #4365

npalm opened this issue Jan 17, 2025 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@npalm
Copy link
Collaborator

npalm commented Jan 17, 2025

Description

Currently API calls to GitHub API are spread through the module lambda Control Plane. This make it hards

  • reuse code
  • refactor code
  • mock with testing

As improvent a new service layer could be introduced (as own module in libs) that proxy GitHub API calls as a services. It will makes mocking in the test much eadier, as well refactoring and re-use.
@npalm npalm added enhancement New feature or request help wanted Extra attention is needed labels Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@npalm