Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red and green reversed in diff view? #146

Open
RandalSchwartz opened this issue Sep 29, 2023 · 3 comments
Open

Red and green reversed in diff view? #146

RandalSchwartz opened this issue Sep 29, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@RandalSchwartz
Copy link

In the diff view, red and green seem to be reversed. Red should be for things going away, and green for things being added, but in the video I saw it reversed, and I have confirmed it happening right now.

@nisha-bito
Copy link
Contributor

hi @RandalSchwartz ,

Please suggest if you are using VS code or JetBrains ?

In VS code and JB, we keep the original file in the right side and Bito suggested code/file in the left side.
VS code only supports merging code from left to right icon, this will give ease of adding code in the right/original file with fewer clicks.

image

Thanks,
Nisha

@RandalSchwartz
Copy link
Author

Using VSCode yes. But still, I think of "green" as "being added" or "will be the result", and red as "moving away from". But you just confirmed that it is precisely the opposite of that. So I wasn't crazy, and you've deliberately designed it to be backwards. Would you consider perhaps an option to switch those so that I can have an intuitive (to me) display?

@nisha-bito
Copy link
Contributor

hi @RandalSchwartz ,

We will add this in our feature request. Thanks.

Nisha

@nisha-bito nisha-bito added the enhancement New feature or request label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants