Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove JOSS job #1750

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Remove JOSS job #1750

wants to merge 1 commit into from
+0 −37

Conversation

pratikvn
Copy link
Member

Remove the job that compiled the paper for JOSS. The files used (doc/joss/*) have still been left as is for reference, but I think the job is not needed anymore.

@pratikvn pratikvn added reg:ci-cd This is related to the continuous integration system. reg:documentation This is related to documentation. 1:ST:ready-for-review This PR is ready for review reg:paper This is related to a publication. labels Dec 10, 2024
@pratikvn pratikvn requested a review from a team December 10, 2024 11:00
@pratikvn pratikvn self-assigned this Dec 10, 2024
upsj
upsj approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There are some people approaching software publications as "living papers" that evolve alongside the code and documentation, but I don't think we need to do that with the JOSS paper.

@yhmtsai
Copy link
Member

yhmtsai commented Dec 10, 2024

I think it is the JOSS idea, right?
How does it work with changed content? Originally, I thought we only need to update it by ourselve. Do we need to request a review from JOSS site?
We should update some outdated information like we use another json package not rapidjson anymore.

@pratikvn
Copy link
Member Author

I dont think they have support for version updates like Zenodo. It would have to be a new paper (with new reviews and so on), which I think is possible, but I dont think we need to do that, as I dont see any real benefits from that.

@pratikvn pratikvn added the 1:ST:no-changelog-entry Skip the wiki check for changelog update label Dec 10, 2024
@yhmtsai
Copy link
Member

yhmtsai commented Dec 10, 2024

okay, it need to wait until #1747 is merged

@pratikvn pratikvn added 1:ST:ready-to-merge This PR is ready to merge. 1:ST:no-changelog-entry Skip the wiki check for changelog update and removed 1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-for-review This PR is ready for review labels Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj approved these changes

Assignees

@pratikvn pratikvn

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. reg:ci-cd This is related to the continuous integration system. reg:documentation This is related to documentation. reg:paper This is related to a publication.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pratikvn @yhmtsai @upsj