Add specific communicator for neighborhood communication #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
6acf7c4 to
8aa6ab9
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
b42ab92 to
8f104fd
Compare
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
8aa6ab9 to
77398bd
Compare
7 tasks
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
77398bd to
d278cad
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
8f104fd to
a0824a8
Compare
This was referenced Apr 22, 2024
Merged
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
d278cad to
d6112ef
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
a0824a8 to
8ad3f2f
Compare
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
d6112ef to
1582673
Compare
6 tasks
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
1582673 to
db9b48a
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
8ad3f2f to
26678b3
Compare
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
db9b48a to
72eafff
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
26678b3 to
006d67d
Compare
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
72eafff to
3c70106
Compare
MarcelKoch
force-pushed
the
read-distributed-with-index-map
branch
from
006d67d to
b295b11
Compare
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
3c70106 to
a1567b8
Compare
MarcelKoch
force-pushed
the
index-map-pgm
branch
from
ded4dd3 to
3ad5eee
Compare
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
db7f6ed to
0ad4ee8
Compare
pratikvn
reviewed
Aug 16, 2024
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
0ad4ee8 to
1f49b91
Compare
pratikvn
approved these changes
Aug 16, 2024
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
1f49b91 to
4db050c
Compare
MarcelKoch
force-pushed
the
index-map-pgm
branch
from
3ad5eee to
6395054
Compare
upsj
reviewed
Oct 18, 2024
|
@upsj I think the moved-from that should be using |
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
4db050c to
1ebe59f
Compare
MarcelKoch
force-pushed
the
index-map-pgm
branch
2 times, most recently
from
604a6e9 to
ba0982e
Compare
Co-authored-by: Pratik Nayak <[email protected]>
Co-authored-by: Pratik Nayak <[email protected]>
- fix include guards - update docs - implement copy/move constructors/assignment with tests - add equality test for collective communicators (needed for testing) - always enable neighborhood comm, just throw if openmpi is too old - define moved-from state as MPI_COMM_NULL + empty sizes/offsets - remove unnecessary namespace - make virtual function protected Co-authored-by: Pratik Nayak <[email protected]> Co-authored-by: Tobias Ribizel <[email protected]>
MarcelKoch
force-pushed
the
neighborhood-communicator
branch
from
1ebe59f to
e7d32a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a communicator that only handles neighborhood all-to-all communication. It implements the new interface
collective_communicator, which provides different implementations for a selected set of collective mpi routines. Currently, this only includes the non-blocking all-to-all.The communication uses a fixed pattern, i.e. the send/recv sizes are fixed when the neighborhood communicator is constructed. I would have liked to decouple that, but this would require some knowledge of how the sizes are stored at the interface level. If someone has an idea for that, please let me know.
This is the first part of splitting up #1546.
The neighborhood all-to-all has a bug in OpenMPI < v4.1.0, which makes it necessary to disable the neighborhood communicator in this case. As replacement, there is also a dense all-to-all communicator.
Todo:
PR Stack: