Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CITING.md with new papers #1507

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

pratikvn
Copy link
Member

Following the suggestion from @tcojean, this PR adds new papers and sections to the CITING.md file

@pratikvn pratikvn added reg:documentation This is related to documentation. 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Dec 13, 2023
@pratikvn pratikvn requested review from a team December 13, 2023 08:56
@pratikvn pratikvn self-assigned this Dec 13, 2023
@MarcelKoch MarcelKoch self-requested a review December 13, 2023 09:05
Copy link
Member

@MarcelKoch MarcelKoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's missing clear statements on which papers to actually cite. The TOMS paper should probably have something like this at the top:

Please cite this if you are using Ginkgo in your research.

And for the other features there should also be a single paper highlighted, which best represents the feature. (But I get that this might not make sense everywhere.)

@tcojean
Copy link
Member

tcojean commented Dec 13, 2023

Thanks Pratik for taking this up! I agree with Marcel, we should not clutter this file too much. The main point from my PoV is to concentrate citations on e.g. journal papers rather than have a few citations spread over too many papers. It's up to everyone to pick which papers they prefer is cited for their research, but I do think we should keep this list as short as possible.

@pratikvn
Copy link
Member Author

I think that is quite difficult to do. In many cases, papers are mostly intertwined with applications, so specifying one paper for the feature is difficult. I mostly added a few main papers for each, and let the user decide which they want to use. Maybe we can make a rule that we add two papers per section to keep this file limited.

I think maybe one approach would be to have a recommendation only for the main Ginkgo paper, but list maybe two/three papers for each major feature, and let the user decide if they want to cite something additional to the main Ginkgo paper.

Copy link
Member

@tcojean tcojean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments

eprint={2006.14290},
archivePrefix={arXiv},
primaryClass={cs.MS}
@inproceedings{tsaiPreparingGinkgoAMD2021,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the main paper which summarizes these efforts would be:

title = {{Ginkgo—A math library designed for platform portability}},
journal = {{Parallel Computing}},
volume = {111},
pages = {102902},
year = {2022},
issn = {0167-8191},
doi = {https://doi.org/10.1016/j.parco.2022.102902},
url = {https://www.sciencedirect.com/science/article/pii/S0167819122000096},
author = {Terry Cojean and Yu-Hsiang Mike Tsai and Hartwig Anzt},
keywords = {Porting to GPU accelerators, Platform Portability, Performance portability, AMD, NVIDIA, Intel}
}

I generally think it's better to cite journals first or important conferences (e.g., IPDPS).

@@ -119,15 +148,217 @@ articleno = {2},
numpages = {26},
keywords = {irregular matrices, GPUs, Sparse Matrix Vector Product (SpMV)}
}

@inproceedings{anztEvaluatingPerformanceNVIDIA2020,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This paper is hard to put in one place, it's more than sparse to begin with, and also has solvers performance. It's essentially an A100 benchmarking paper, and comparing to V100 performance, I don't know if it fits here.

### Preconditioners

```bibtex
@inproceedings{gobelMixedPrecisionIncomplete2021,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also consider Hartwig and Tobias' ParILUT paper in this section?
https://scholar.google.com/citations?view_op=view_citation&citation_for_view=ctNCF8YAAAAJ:RGFaLdJalmkC

keywords = {Batched preconditioners,Batched solvers,GINKGO,GPU,Sparse linear systems}
}

@inproceedings{kashiBatchedSparseIterative2022,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put IPDPS first I think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-for-review This PR is ready for review 1:ST:skip-full-test reg:documentation This is related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants