Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placement for bottom-start does not re-position when scrolling #946

Open
bfrable opened this issue Oct 4, 2023 · 5 comments
Open

Placement for bottom-start does not re-position when scrolling #946

bfrable opened this issue Oct 4, 2023 · 5 comments

Comments

@bfrable
Copy link

bfrable commented Oct 4, 2023

🐛 Bug Report

I've noticed when using bottom-start or top-start for placement, the tooltip does not auto re-position when scrolling according to the amount of the space within the element and the browser.

Bottom works as expected, left-start works as expected. All of the options seem to work except top-start and bottom-start.

To Reproduce

https://codesandbox.io/s/heuristic-chaum-kpd7kr?file=/src/Basic/index.tsx

The above codesandbox of your demo site shows that bottom-start does not auto re-position

To compare, react-floater sandbox demo site, bottom-start does work.

https://codesandbox.io/s/festive-grothendieck-gxk34v?file=/src/examples/WithStyledComponents.tsx:1198-1230

Expected behavior

'bottom-start' and 'top-start' re-position accordingly on scroll

Link to repl or repo (highly encouraged)

React Joyride Demo Site Example.

@bfrable
Copy link
Author

bfrable commented Oct 4, 2023

This is resolved when using the latest version of floater.

@klassm
Copy link

klassm commented Jan 22, 2024

With react-floater 0.9.3 more stuff seems to break. Is there a plan to release a new version of react-joyride including the latest version of react-floater? Thanks :-)

@gilbarbara
Copy link
Owner

Hey @klassm

With react-floater 0.9.3 more stuff seems to break.
What does this mean?

And yes, I'll work on the upgrade when I have some time, but since it's a breaking change, it'll have to wait for some other upgrades.

@klassm
Copy link

klassm commented Jan 23, 2024

We tried to just use react-floater 0.9.3 with the latest version of react-joyride. It compiles, but whenever you point to an item the beacon shows up, while it actually has been disabled. Not sure what else also breaks, we stopped looking there :-)

@klassm
Copy link

klassm commented Sep 6, 2024

At @gilbarbara: Did you already have a chance to look into this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants