From 9797272186974b35016e69bcafe4132a69846836 Mon Sep 17 00:00:00 2001 From: Serhiy Date: Fri, 29 Dec 2017 10:34:05 +0200 Subject: [PATCH 1/2] Sf4, update composer.json --- composer.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/composer.json b/composer.json index 44a90be..148c343 100644 --- a/composer.json +++ b/composer.json @@ -20,10 +20,10 @@ "pear/versioncontrol_git": "^0.5", "pear/pear-core-minimal": "^1.9", "pear/pear_exception": "^1.0", - "symfony/console": "^2.8|^3.0", - "symfony/filesystem": "^2.8|^3.0", - "symfony/process": "^2.8|^3.0", - "symfony/finder": "^2.8|^3.0" + "symfony/console": "^2.8|^3.0|^4.0", + "symfony/filesystem": "^2.8|^3.0|^4.0", + "symfony/process": "^2.8|^3.0|^4.0", + "symfony/finder": "^2.8|^3.0|^4.0" }, "autoload": { "psr-4": { From 62a807febc6f484273d769e559131bd8b2d8bb40 Mon Sep 17 00:00:00 2001 From: Serhiy Martynovych Date: Fri, 29 Dec 2017 22:21:17 +0200 Subject: [PATCH 2/2] Change deprecated ProcessBuilder --- tests/PhingCompareTest.php | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/tests/PhingCompareTest.php b/tests/PhingCompareTest.php index bacd4f3..c83ff79 100644 --- a/tests/PhingCompareTest.php +++ b/tests/PhingCompareTest.php @@ -5,7 +5,7 @@ use Symfony\Component\Filesystem\Filesystem; use Symfony\Component\Finder\Finder; use Symfony\Component\Finder\SplFileInfo; -use Symfony\Component\Process\ProcessBuilder; +use Symfony\Component\Process\Process; class PhingCompareTest extends \PHPUnit_Framework_TestCase { @@ -35,13 +35,8 @@ public static function tearDownAfterClass() public function testRunningPhing() { // Run phing compile - $builder = new ProcessBuilder(); - $builder->setPrefix(__DIR__ . '/../vendor/bin/phing'); - $builder->setWorkingDirectory(__DIR__ . '/../'); - $builder->setArguments(array('compile')); - - $process = $builder->getProcess(); - + $process = new Process(__DIR__ . '/../vendor/bin/phing compile'); + $process->setWorkingDirectory(__DIR__ . '/../'); $process->run(); // Print this for keepsakes