-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal closes when selecting a field. #505
Comments
One possible solution could be to add the below check before closing the modal on clicking the overlay if (document.getSelection().type === "Range") {
return;
} |
Same thing here, this seems like quite a big issue to have if someone is just interacting with the content. |
Same issue here, very simple install, clicking on certain areas of the "modal__container", close the modal down for me. It's triggering the overlay close even though I'm clicking within the modal, surely that's not right? |
I "solved" this by manually adding mousedown event listener to the overlay element.
The |
👋 Hello here! One simple fix would be to have the overlay on its own. At the moment the content of the modal |
Current behavior - Selecting a field or text in the modal closes it if mouse is dragged outside the modal.
Example from zulip project-
Can be reproduced while selecting some text in the demo modal in documentation as well.
Expected behavior - Modal should not closed if mouse ends up outside the modal while selecting something.
The text was updated successfully, but these errors were encountered: