Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue with Example30 scss file, invalid rgb value, fixes #427 #428

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

baj1210
Copy link
Contributor

@baj1210 baj1210 commented Oct 30, 2024

fixed Example30.scss color arguments

fixed rgba arguments
corrected colors to original
Copy link

stackblitz bot commented Oct 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@ghiscoding ghiscoding changed the title Patch 1 fix: issue with Example30 scss file, invalid rgb value, fixes #427 Oct 30, 2024
@baj1210
Copy link
Contributor Author

baj1210 commented Oct 30, 2024

pull requests are exciting!

@baj1210 baj1210 closed this Oct 30, 2024
@ghiscoding ghiscoding merged commit 28cad57 into ghiscoding:master Oct 30, 2024
2 checks passed
@ghiscoding
Copy link
Owner

ghiscoding commented Oct 30, 2024

Thanks for the contribution, side note, I rename the title because I use Conventional Commits so that the system can automatically update the changelog and also show in the release. So any prefix with fix:, feat: will show up in the changelogs but anything else (like chore:) will not. Example might not have to show in the changelogs but I think this one was ok to appear in there, so I changed it to fix:...

Also for your info, the CI runs all the E2E tests every time a Pull Request is created which is also why I like to have all these examples separate. If a E2E test fails it's easier to debug

@baj1210
Copy link
Contributor Author

baj1210 commented Oct 30, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants