Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci : faster CUDA toolkit installation method and use ccache #10537

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Conversation

slaren
Copy link
Collaborator

@slaren slaren commented Nov 27, 2024

ccache could be enabled for other builds, it makes a big difference. When building PRs, it should reuse the cache from the parent build in master.

Credit where it's due: I took the CUDA installation method from the CI in karpathy llm.c

Fixes #10486

@github-actions github-actions bot added the devops improvements to build systems and github actions label Nov 27, 2024
Copy link
Collaborator

@JohannesGaessler JohannesGaessler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If ccache actually helps we obviously should use it though I'm confused that it does. That would imply that there is persistent storage between different CI builds which to my knowledge there shouldn't be.

@slaren
Copy link
Collaborator Author

slaren commented Nov 27, 2024

Github has a cache that allows data to be kept between builds. The name of the step is a bit misleading, it doesn't just install ccache, it also restores the ccache cache from the github cache.
https://github.com/ggerganov/llama.cpp/actions/caches

@slaren slaren merged commit 46c69e0 into master Nov 27, 2024
46 checks passed
@slaren slaren deleted the sl/ci-ccache branch November 27, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Improve CI speed of CUDA on Windows
2 participants