Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings cap per entity should be applied for unique warnings only #612

Open
yaelmi3 opened this issue Aug 5, 2020 · 0 comments
Open

Warnings cap per entity should be applied for unique warnings only #612

yaelmi3 opened this issue Aug 5, 2020 · 0 comments

Comments

@yaelmi3
Copy link
Contributor

yaelmi3 commented Aug 5, 2020

Currently we're capping the number of recorded warnings per entity to 50, but do not distinguish between repeated warnings and unique warnings. This might cause situation where unique warnings will be omitted from the display. For example:

    for _ in range(50):
        warnings.warn("Hi")
    warnings.warn("Bye")

will result in:
image

and "Bye" will be omitted from the display

vmalloc added a commit that referenced this issue Aug 9, 2020
Count unique warnings to avoid omitting unique warnings (issue #612)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant