Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exceptions should handle ansi colors #589

Open
ayalash opened this issue Dec 11, 2019 · 3 comments
Open

Exceptions should handle ansi colors #589

ayalash opened this issue Dec 11, 2019 · 3 comments
Assignees
@ayalash
Labels
C-enhancement P-high

Comments

@ayalash
Copy link
Contributor

ayalash commented Dec 11, 2019 •
edited
Loading

Example for exception message:

...
error: Found argument '--ignore-dir' which wasn't expected, or isn't valid in this context
	Did you mean �[32m--�[0m�[32mignored-dirs�[0m?

USAGE:
... For more information try --help ...
@ayalash
Copy link
Contributor Author

ayalash commented Dec 11, 2019

@vmalloc I'm not sure if we want to ignore the ansi colors or display them as colored text. What do you think?

@vmalloc
Copy link
Member

vmalloc commented Dec 11, 2019

It would be nice to show them correctly, of course...

@ayalash
Copy link
Contributor Author

ayalash commented Dec 11, 2019

I found this package. I'll try using it from backslash:
https://github.com/drudru/ansi_up

@ayalash ayalash self-assigned this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ayalash ayalash

Labels
C-enhancement P-high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vmalloc @ayalash