-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error accumulating test counters in frontend #578
Comments
@vmalloc Any suggestions? |
Perhaps we can have a boolean field for tests called "counted", defaulting to NULL to save on the migration time. Operations attempting to increment the counters for the session will only do this if this field is false, and then set it to true? |
@vmalloc I think you want to count both interruptions and errors (for example, if test had error and interrupted afterwards - you want it to be shown in session view). |
That's possible... the only problem is that after this change previous runs would show incorrectly... |
When running a session with interrupted test, this test can also have errors.
In this case both session.num_error_tests and session.num_interrupted_tests incremented.
This causes the session.num_successful_tests to be wrong.
The text was updated successfully, but these errors were encountered: