Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error accumulating test counters in frontend #578

Open
maormarcus opened this issue Sep 25, 2019 · 4 comments
Open

error accumulating test counters in frontend #578

maormarcus opened this issue Sep 25, 2019 · 4 comments
Assignees

Comments

@maormarcus
Copy link
Contributor

When running a session with interrupted test, this test can also have errors.
In this case both session.num_error_tests and session.num_interrupted_tests incremented.
This causes the session.num_successful_tests to be wrong.

@ayalash
Copy link
Contributor

ayalash commented Oct 10, 2019

@vmalloc Any suggestions?

@vmalloc
Copy link
Member

vmalloc commented Oct 10, 2019

Perhaps we can have a boolean field for tests called "counted", defaulting to NULL to save on the migration time. Operations attempting to increment the counters for the session will only do this if this field is false, and then set it to true?

@maormarcus
Copy link
Contributor Author

@vmalloc I think you want to count both interruptions and errors (for example, if test had error and interrupted afterwards - you want it to be shown in session view).
Maybe adding to the session model num_successful_tests and in report_test_end update it as well?

@vmalloc
Copy link
Member

vmalloc commented Oct 29, 2019

That's possible... the only problem is that after this change previous runs would show incorrectly...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants