Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protocol: Send envelope types with requests #73

Open
mwarkentin opened this issue Mar 19, 2024 · 3 comments
Open

Protocol: Send envelope types with requests #73

mwarkentin opened this issue Mar 19, 2024 · 3 comments

Comments

@mwarkentin
Copy link
Member

mwarkentin commented Mar 19, 2024

Description

We currently have no visibility into the type of event that we are dealing with in any of our systems before we hit relay. These are mainly the Google load balancer and our anti-abuse PoP layers.

An example of this issue came up in INC-648, where there are submitted events receiving errors from the GLB and never making their way to our backend systems. It's difficult to understand what type of events are running into these issues.

RFC

No response

Slack-Channel

#inc-648

Notion Document(s)

INC-648 doc

Stakeholder(s)

INC-648, SRE

Team(s)

No response

@sl0thentr0py
Copy link
Member

questions

  • is this a new http header?
  • i assume we just take the first item type if the envelope has multiple items

@AbhiPrasad AbhiPrasad changed the title Send envelope type as header Send envelope type with requests to Relay Mar 19, 2024
@AbhiPrasad AbhiPrasad changed the title Send envelope type with requests to Relay Send envelope type with requests to ingestion Mar 19, 2024
@AbhiPrasad
Copy link
Member

is this a new http header?

We can also send as a query param, this feels like an implementation detail so I edited the issue accordingly.

i assume we just take the first item type if the envelope has multiple items

Yup first envelope item seems safest to send

@mwarkentin
Copy link
Member Author

@AbhiPrasad I wonder if it would be possible to make this a (comma-separated?) list or array of types if there are multiple items? I'm not sure how common it is for multiple types to be grouped together or not.

@stephanie-anderson stephanie-anderson changed the title Send envelope type with requests to ingestion Protocol: Send envelope types with requests Jun 18, 2024
@stephanie-anderson stephanie-anderson modified the milestones: [1] Discovery, [5] On Hold, Protocol Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Needs Discussion
Development

No branches or pull requests

7 participants