Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to bookmark a project #82770

Closed
kerenkhatiwada opened this issue Dec 31, 2024 · 3 comments · Fixed by #82832
Closed

Unable to bookmark a project #82770

kerenkhatiwada opened this issue Dec 31, 2024 · 3 comments · Fixed by #82832
Labels
Product Area: Settings - Projects

Comments

@kerenkhatiwada
Copy link
Member

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. bookmark a project
  2. refresh the page
  3. observe the project is no longer bookmarked

Network request payload shows isBookmarked: falseImage

Expected Result

Project is bookmarked after refresh

Actual Result

Project is not bookmarked after refresh

Product Area

Settings - Projects

Link

No response

DSN

No response

Version

No response
@getsantry
Copy link
Contributor

getsantry bot commented Dec 31, 2024

Assigning to @getsentry/support for routing ⏲️

@getsantry getsantry bot moved this to Waiting for: Support in GitHub Issues with 👀 3 Dec 31, 2024
@getsantry
Copy link
Contributor

getsantry bot commented Dec 31, 2024

Routing to @getsentry/product-owners-settings-projects for triage ⏲️

@getsantry getsantry bot moved this from Waiting for: Support to Waiting for: Product Owner in GitHub Issues with 👀 3 Dec 31, 2024
@leedongwei
Copy link
Member

I've replicated it and will get someone to fix it.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 3 Jan 2, 2025
scttcper added a commit that referenced this issue Jan 2, 2025
@scttcper
fix(settings): Bookmark toggling wrong direction
98b0b81 
onMutate is being fired before the mutationFn making the bookmark toggle the wrong way.

fixes #82770
@scttcper scttcper mentioned this issue Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Product Area: Settings - Projects
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(settings): Bookmark toggling wrong direction getsentry/sentry
2 participants
@leedongwei @kerenkhatiwada