From fefe11e6e42eb9dcfe71d026a9b8157855342e51 Mon Sep 17 00:00:00 2001
From: Volo Kluev <volo.kluev@sentry.io>
Date: Wed, 25 Sep 2024 11:15:41 -0700
Subject: [PATCH] OP_IN, OP_NOT_IN

---
 .../snuba/v1/endpoint_trace_item_attributes.proto      |  1 +
 .../sentry_protos/snuba/v1/trace_item_attribute.proto  | 10 ++++++++++
 proto/sentry_protos/snuba/v1/trace_item_filter.proto   |  2 ++
 3 files changed, 13 insertions(+)

diff --git a/proto/sentry_protos/snuba/v1/endpoint_trace_item_attributes.proto b/proto/sentry_protos/snuba/v1/endpoint_trace_item_attributes.proto
index a5b6b5f..2441786 100644
--- a/proto/sentry_protos/snuba/v1/endpoint_trace_item_attributes.proto
+++ b/proto/sentry_protos/snuba/v1/endpoint_trace_item_attributes.proto
@@ -16,6 +16,7 @@ message TraceItemAttributeNamesRequest {
   // different typed attributes are queried separately
   // anything other than TYPE_STRING and TYPE_FLOAT will return empty
   AttributeKey.Type type = 5;
+  string value_substring_match = 6;
 }
 
 message TraceItemAttributeNamesResponse {
diff --git a/proto/sentry_protos/snuba/v1/trace_item_attribute.proto b/proto/sentry_protos/snuba/v1/trace_item_attribute.proto
index b323e58..ed0c559 100644
--- a/proto/sentry_protos/snuba/v1/trace_item_attribute.proto
+++ b/proto/sentry_protos/snuba/v1/trace_item_attribute.proto
@@ -29,6 +29,14 @@ message VirtualColumnContext {
   map<string, string> value_map = 3;
 }
 
+message StrArray {
+  repeated string values = 1;
+}
+
+message IntArray {
+  repeated int64 values = 1;
+}
+
 message AttributeValue {
   oneof value {
     bool val_bool = 1;
@@ -37,5 +45,7 @@ message AttributeValue {
     int64 val_int = 4;
     // set to true if value is null
     bool val_null = 5;
+    StrArray val_str_array = 6;
+    IntArray val_int_array = 7;
   }
 }
diff --git a/proto/sentry_protos/snuba/v1/trace_item_filter.proto b/proto/sentry_protos/snuba/v1/trace_item_filter.proto
index 8c4d175..d8b7c76 100644
--- a/proto/sentry_protos/snuba/v1/trace_item_filter.proto
+++ b/proto/sentry_protos/snuba/v1/trace_item_filter.proto
@@ -27,6 +27,8 @@ message ComparisonFilter {
     OP_NOT_EQUALS = 6;
     OP_LIKE = 7; //string only
     OP_NOT_LIKE = 8; //string only
+    OP_IN = 9; // array only
+    OP_NOT_IN = 10; // array only
   }
   AttributeKey key = 1;
   Op op = 2;