Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export esbuild plugin as default #555

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Conversation

lforst
Copy link
Member

@lforst lforst commented Jun 24, 2024

Fixes #554

We tell users in our docs for setting up the esbuild plugin with Angular and Nx to pass the plugin to the plugins array in the Nx config. However, Nx just takes the default export, or if non-existent, whatever is on module.exports, as the plugin.

If we export the plugin as default export the issue is fixed.

@lforst lforst merged commit 604077b into main Jun 24, 2024
16 checks passed
@lforst lforst deleted the lforst-esbuild-default-export branch June 24, 2024 08:08
This was referenced Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

esbuild plugin causing error in Nx Angular CLI (angular 17)
2 participants