Skip to content

Commit 3c2da32

Browse files
test: apply AAA pattern and DAMP to SentryByteCountFormatterTests
Refactored SentryByteCountFormatterTests to follow Arrange-Act-Assert pattern with explicit comment markers. Inlined helper method to make tests DAMP (Descriptive And Meaningful Phrases) - each test is now self-contained and readable without jumping to helper methods. Added descriptive constants (halfKbSize, kbSize) and variable names (singleUnitResult, midRangeResult, maxValueResult) to eliminate magic numbers and improve clarity. Fixed operator precedence for boundary value calculation - using 'baseValue * kbSize - 1' preserves correct semantics.
1 parent 3c86dec commit 3c2da32

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

Tests/SentryTests/Helper/SentryByteCountFormatterTests.swift

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ import XCTest
22

33
class SentryByteCountFormatterTests: XCTestCase {
44

5-
private let midRangeMultiplier: UInt = 512
6-
private let maxValueOffset: UInt = 1_024 - 1
5+
private let halfKbSize: UInt = 512
6+
private let kbSize: UInt = 1_024
77

88
func testBytesDescription() {
99
// -- Arrange --
@@ -12,8 +12,8 @@ class SentryByteCountFormatterTests: XCTestCase {
1212

1313
// -- Act --
1414
let singleUnitResult = SentryByteCountFormatter.bytesCountDescription(baseValue)
15-
let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * midRangeMultiplier)
16-
let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * maxValueOffset)
15+
let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * halfKbSize)
16+
let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * kbSize - 1)
1717

1818
// -- Assert --
1919
XCTAssertEqual("1 \(unitName)", singleUnitResult)
@@ -23,13 +23,13 @@ class SentryByteCountFormatterTests: XCTestCase {
2323

2424
func testKBDescription() {
2525
// -- Arrange --
26-
let baseValue: UInt = 1_024
26+
let baseValue: UInt = kbSize
2727
let unitName = "KB"
2828

2929
// -- Act --
3030
let singleUnitResult = SentryByteCountFormatter.bytesCountDescription(baseValue)
31-
let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * midRangeMultiplier)
32-
let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * maxValueOffset)
31+
let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * halfKbSize)
32+
let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * kbSize - 1)
3333

3434
// -- Assert --
3535
XCTAssertEqual("1 \(unitName)", singleUnitResult)
@@ -39,13 +39,13 @@ class SentryByteCountFormatterTests: XCTestCase {
3939

4040
func testMBDescription() {
4141
// -- Arrange --
42-
let baseValue: UInt = 1_024 * 1_024
42+
let baseValue: UInt = kbSize * kbSize
4343
let unitName = "MB"
4444

4545
// -- Act --
4646
let singleUnitResult = SentryByteCountFormatter.bytesCountDescription(baseValue)
47-
let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * midRangeMultiplier)
48-
let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * maxValueOffset)
47+
let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * halfKbSize)
48+
let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * kbSize - 1)
4949

5050
// -- Assert --
5151
XCTAssertEqual("1 \(unitName)", singleUnitResult)
@@ -55,13 +55,13 @@ class SentryByteCountFormatterTests: XCTestCase {
5555

5656
func testGBDescription() {
5757
// -- Arrange --
58-
let baseValue: UInt = 1_024 * 1_024 * 1_024
58+
let baseValue: UInt = kbSize * kbSize * kbSize
5959
let unitName = "GB"
6060

6161
// -- Act --
6262
let singleUnitResult = SentryByteCountFormatter.bytesCountDescription(baseValue)
63-
let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * midRangeMultiplier)
64-
let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * maxValueOffset)
63+
let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * halfKbSize)
64+
let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * kbSize - 1)
6565

6666
// -- Assert --
6767
XCTAssertEqual("1 \(unitName)", singleUnitResult)

0 commit comments

Comments
 (0)