test: apply AAA pattern and DAMP to SentryByteCountFormatterTests

Refactored SentryByteCountFormatterTests to follow Arrange-Act-Assert
pattern with explicit comment markers. Inlined helper method to make
tests DAMP (Descriptive And Meaningful Phrases) - each test is now
self-contained and readable without jumping to helper methods.

Added descriptive constants (halfKbSize, kbSize) and variable names
(singleUnitResult, midRangeResult, maxValueResult) to eliminate
magic numbers and improve clarity.

Fixed operator precedence for boundary value calculation - using
'baseValue * kbSize - 1' preserves correct semantics.

Author: philipphofmann

Tests/SentryTests/Helper/SentryByteCountFormatterTests.swift

@@ -2,8 +2,8 @@ import XCTest
 
 class SentryByteCountFormatterTests: XCTestCase {
 
-    private let midRangeMultiplier: UInt = 512
-    private let maxValueOffset: UInt = 1_024 - 1
+    private let halfKbSize: UInt = 512
+    private let kbSize: UInt = 1_024
 
     func testBytesDescription() {
         // -- Arrange --
@@ -12,8 +12,8 @@ class SentryByteCountFormatterTests: XCTestCase {
 
         // -- Act --
         let singleUnitResult = SentryByteCountFormatter.bytesCountDescription(baseValue)
-        let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * midRangeMultiplier)
-        let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * maxValueOffset)
+        let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * halfKbSize)
+        let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * kbSize - 1)
 
         // -- Assert --
         XCTAssertEqual("1 \(unitName)", singleUnitResult)
@@ -23,13 +23,13 @@ class SentryByteCountFormatterTests: XCTestCase {
 
     func testKBDescription() {
         // -- Arrange --
-        let baseValue: UInt = 1_024
+        let baseValue: UInt = kbSize
         let unitName = "KB"
 
         // -- Act --
         let singleUnitResult = SentryByteCountFormatter.bytesCountDescription(baseValue)
-        let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * midRangeMultiplier)
-        let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * maxValueOffset)
+        let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * halfKbSize)
+        let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * kbSize - 1)
 
         // -- Assert --
         XCTAssertEqual("1 \(unitName)", singleUnitResult)
@@ -39,13 +39,13 @@ class SentryByteCountFormatterTests: XCTestCase {
 
     func testMBDescription() {
         // -- Arrange --
-        let baseValue: UInt = 1_024 * 1_024
+        let baseValue: UInt = kbSize * kbSize
         let unitName = "MB"
 
         // -- Act --
         let singleUnitResult = SentryByteCountFormatter.bytesCountDescription(baseValue)
-        let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * midRangeMultiplier)
-        let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * maxValueOffset)
+        let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * halfKbSize)
+        let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * kbSize - 1)
 
         // -- Assert --
         XCTAssertEqual("1 \(unitName)", singleUnitResult)
@@ -55,13 +55,13 @@ class SentryByteCountFormatterTests: XCTestCase {
 
     func testGBDescription() {
         // -- Arrange --
-        let baseValue: UInt = 1_024 * 1_024 * 1_024
+        let baseValue: UInt = kbSize * kbSize * kbSize
         let unitName = "GB"
 
         // -- Act --
         let singleUnitResult = SentryByteCountFormatter.bytesCountDescription(baseValue)
-        let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * midRangeMultiplier)
-        let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * maxValueOffset)
+        let midRangeResult = SentryByteCountFormatter.bytesCountDescription(baseValue * halfKbSize)
+        let maxValueResult = SentryByteCountFormatter.bytesCountDescription(baseValue * kbSize - 1)
 
         // -- Assert --
         XCTAssertEqual("1 \(unitName)", singleUnitResult)