-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replay is too slow on 1.0.0-beta.1 #708
Comments
Hi and thank you for opening this issue! "@sentry/angular": "8.9.2",
"@sentry/capacitor": "1.0.0-beta.1" EDIT: In regard to sentry_version being 7, despite the number being similar to the previous version of Sentry Javascript, it's actually unrelated, it's just the protocol version we are using to communicate with the server. |
Thanks for your quick answer. Using |
Is there any "stable workaround" to use the previous version of this package with angular 18? |
Update: it looks like if I remove these lines the app works good again: replaysSessionSampleRate: 0.1,
replaysOnErrorSampleRate: 1.0, So this is now my winning Sentry config import * as Sentry from '@sentry/capacitor';
import * as SentryAngular from '@sentry/angular';
...
Sentry.init(
{
dsn: environment.sentryDsn,
release: `...@${packageInfo.version}`,
// replaysSessionSampleRate: 0.1,
// replaysOnErrorSampleRate: 1.0,
enabled: environment.production,
environment: environment.title ?? 'develop',
ignoreErrors: [...],
integrations: [Sentry.replayIntegration(), SentryAngular.browserTracingIntegration()],
tracePropagationTargets: ['localhost', environment.API_URL],
tracesSampleRate: environment.title === 'production' ? 0.75 : 1
},
SentryAngular.init
); I saw in the code that |
Vue 3 Capacitor 6, @sentry/vue v8.24.0 same: import * as Sentry from '@sentry/capacitor'
import * as SentryVue from '@sentry/vue'
Sentry.init(
{
app,
dsn: import.meta.env.VUE_APP_SENTRY_URL,
integrations: [
SentryVue.browserTracingIntegration({ router }),
Sentry.replayIntegration(),
],
tracePropagationTargets: ['localhost', /^\//],
tracesSampleRate: 1.0,
// replaysSessionSampleRate: 0.1,
//replaysOnErrorSampleRate: 1.0,
environment,
//dist,
//release,
},
SentryVue.init
) solution: |
Also for vue, you also need to use the speicif version of @sentry/vue "8.9.2" |
I am sorry for your experience, did it also happen on the previous version? |
@lucas-zimerman thx for Vue |
No, it didn't happen before. |
We stayed on a fixed version for the first beta, but future betas will have the latest version |
Is there an indicative date that version 1.0.0 will be out of beta? |
We will ship a release candidate next week, you can expect the final 1.0.0 in a few weeks time at the latest |
Since the issue with conflicting packages were sorted out, I will reuse this issue to track the replay slowness with the latest version. |
@djabif sorry for the late question, are you experiencing the slowness with replay on web, app or both? |
Hi, sorry for the late reply. I was experiencing the slowness only in the app. |
Environment
Steps to Reproduce
Expected Result
New version should log errors and messages in Sentry the same way as the previous version.
Actual Result
I'm having a type error in the
integrations
array because of theSentryAngular.browserTracingIntegration()
. If I removebrowserTracingIntegration
and only setintegrations: [Sentry.replayIntegration()]
, I don't get any error.The error is:
So that's one thing but even if I remove the
browserTracingIntegration
, with this new version I'm not able to see the logs in sentry.I ran the migration script and changed
@sentry/angular-ivy
in favor of@sentry/angular
... am I missing something?I also noted in my browser network that the sentry requests have the
sentry_version=7
param... is that ok or should it be8
?https://xx.ingest.sentry.io/api/xx/envelope/?sentry_key=xxx&sentry_version=7&sentry_client=sentry.javascript.angular%2F8.24.0
Thanks
The text was updated successfully, but these errors were encountered: