-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying the version of craft used for publishing a release #664
Comments
You'd need to find a way to incorporate and relay that information through the issue format. I'd say it is definitely not worth the hassle and complexity as you can easily pin/fix the craft version. A more important issue is |
The publish process always use the latest Craft Docker image (with the latest published version of the
craft
binary):publish/.github/workflows/publish.yml
Lines 49 to 50 in e991410
Craft releases themselves are published with this repository workflow. Whenever there's a broken Craft release, all releases, including Craft's, are affected and require manual operator intervention as in #577, where we had to temporarily hard-pin the image version to a known state to unblock releases.
We could make an operator's life easier, and their job safer, by allowing the version to be chosen without requiring temporary patches to the publish workflow.
How exactly that's done is up for debate. Some options:
.craft.yml
config of the target repoAll with pros and cons.
The text was updated successfully, but these errors were encountered: