Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Craft fails the release-registry target if version already exists #405

Open
bruno-garcia opened this issue Jul 12, 2022 · 3 comments
Open

Comments

@bruno-garcia
Copy link
Member

bruno-garcia commented Jul 12, 2022

When we add a new package to release-registry, it's intuition for folks to add the version we're about to release.
The one that actually has that package.

Craft can't handle that, and crashes if the version already exists:

image

If the package isn't there, craft also fails. So we're required to add it manually first.

Request: Please ignore when the package already exists and carry on the release.

@asottile-sentry
Copy link
Member

@bruno-garcia can you link the run for this? I'm not sure I completely understand all the moving parts here and would like to see where the trace is coming from

@adinauer
Copy link
Member

@asottile-sentry I think this is the run that failed: https://github.com/getsentry/publish/runs/7302721278?check_suite_focus=true

We usually manually add new modules to https://github.com/getsentry/sentry-release-registry like here https://github.com/getsentry/sentry-release-registry/pull/78/files . We have to pick a version that we add there.

Let's assume we want to add a new module for 6.3.0, we can't just add it to the release registry as 6.3.0 as the release build will then fail like the one bruno mentioned (linked at the start of my message). So we have to add it to the release registry with an older version that doesn't really exist to make the release work.

@asottile-sentry
Copy link
Member

hmmm -- if you create the release manually should you then check the registry box in the publish issue so it skips the (already done) one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants