Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structure with disallowed duplication has no delete label #6870

Open
adamkiss opened this issue Dec 16, 2024 · 1 comment
Open

Structure with disallowed duplication has no delete label #6870

adamkiss opened this issue Dec 16, 2024 · 1 comment

Comments

@adamkiss
Copy link
Contributor

Description

When you turn off row duplication for a structure field, the delete label is empty for whatever reason.

Observed in v4.2.0, v4.5.0 and v5-beta.1.

Expected behavior
Duplication is disallowed, delete button is visible normally.

Screenshots

CleanShot 2024-12-16 at 22 53 34@2x
CleanShot 2024-12-16 at 22 53 52@2x

To reproduce

Minimal test working in every site I tried this in (four total):

test:
  type: structure
  label: Structure test
  duplicate: false
  fields:
    whatever:
      type: text
@adamkiss
Copy link
Contributor Author

Tracked it down here

text: more ? this.$t("delete") : null,

more is set here:

let more = this.duplicate && this.more;

Don't know what exactly more should do, but the whole line doesn't make sense (add the button, but set the text to null if completely unrelated thing is set to false?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant