Writer field: getting console error when no buttons available for inline mode

[afbora]

Description

Getting console error when no marks or nodes available for inline mode. Try to select a text in writer field and check the console.

writer:
    type: writer
    marks: false
    nodes: false

TypeError: this.$el.getBoundingClientRect is not a function

Your setup

Kirby Version

4.5.0

[distantnative]

@afbora That isn't by any chance also fixed by #6846?

[afbora]

@distantnative No. That PR fixes the fixed toolbar at the top. I think the problem is related to the toolbar that appears in inline mode.

[afbora]

@distantnative We can fix this issue in #6846 with just one line. Do you want to me push fix commit to #6846 ?

[distantnative]

@afbora what line is it?

[afbora]

@distantnative

open() {
+  if (this.buttons.length === 0) {
+    return;
+  }

  this.isOpen = true;
	
  if (this.inline) {
  this.$nextTick(this.setPosition);
}

kirby/panel/src/components/Forms/Writer/Toolbar.vue

Lines 279 to 285 in 4b810c1

	open() {
	this.isOpen = true;
	if (this.inline) {
	this.$nextTick(this.setPosition);
	}
	},

[distantnative]

Does it also works with check if the this.$refs.toolbar exists?

[afbora]

@distantnative Error is gone when I test with following but inline toolbar is completely missing as default writer field:

open() {
  if (!this.$refs.toolbar) {
    return;
  }
  
  // other codes..
}

[afbora]

You checked buttons.length for that issue. I think also it would be nice fix for this issue.

open() {
  if (this.buttons.length === 0) {
    return;
  }
  
  // other codes..