Merge pull request #247 from MariusCiocanel/fix-nil-string-on-NSTextField-crash

set email and personal message only if they are not nil

Author: vineetchoudhary

AppBox/ViewController/HomeViewController/HomeViewController.m

@@ -124,9 +124,7 @@ -(void)setupUploadManager{
 - (void)initCIProcess:(NSNotification *)notification {
     if ([notification.object isKindOfClass:[XCProject class]]) {
         self.ciRepoProject = notification.object;
-        if (self.ciRepoProject.ipaFullPath) {
-            [self initIPAUploadProcessForURL:self.ciRepoProject.ipaFullPath];
-        }
+        [self initIPAUploadProcessForCIProject:self.ciRepoProject];
     }
 }
 
@@ -165,13 +163,22 @@ - (IBAction)selectedFilePathHandler:(NSPathControl *)sender {
     }
 }
 
-- (void)initIPAUploadProcessForURL:(NSURL *)ipaURL {
+- (void)initIPAUploadProcessForCIProject:(XCProject *)ciProject {
+    NSURL *ipaURL = ciProject.ipaFullPath;
+    if (ipaURL == nil) {
+        return;
+    }
+
     [self viewStateForProgressFinish:YES];
     [self.project setIpaFullPath:ipaURL];
     [selectedFilePath setURL:ipaURL];
-    [textFieldEmail setStringValue:self.project.emails];
-    [textFieldMessage setStringValue:self.project.personalMessage];
-    [buttonUniqueLink setState:self.project.keepSameLink.boolValue ? NSOnState : NSOffState];
+    if (ciProject.emails.length != 0) {
+        [textFieldEmail setStringValue:ciProject.emails];
+    }
+    if (ciProject.personalMessage.length != 0) {
+        [textFieldMessage setStringValue:ciProject.personalMessage];
+    }
+    [buttonUniqueLink setState:ciProject.keepSameLink.boolValue ? NSOnState : NSOffState];
     [self actionButtonTapped:buttonAction];
 }