Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Enable more lints #951

Closed
thomaseizinger opened this issue Dec 22, 2021 · 0 comments · Fixed by #1246
Closed

Enable more lints #951

thomaseizinger opened this issue Dec 22, 2021 · 0 comments · Fixed by #1246
Assignees
@thomaseizinger
Labels
enhancement New feature or request productivity Tasks that help our productivity.

Comments

@thomaseizinger
Copy link
Contributor

These lints look interesting to enable as warn:

The latter one might cause problems with us having a library crate because some dependencies are only used in the binary or library. One example that comes to my mind is clap. Thus, as part of enabling this, we probably need to split our workspace into:

  • maker
  • taker
  • some-common-library

To enable the lints across all crates in our workspace, take some inspiration from this PR: EmbarkStudios/rust-ecosystem#68.
@thomaseizinger thomaseizinger added enhancement New feature or request productivity Tasks that help our productivity. labels Dec 22, 2021
@thomaseizinger thomaseizinger linked a pull request Feb 1, 2022 that will close this issue
Enable more lints across the workspace #1246
Merged
@thomaseizinger thomaseizinger self-assigned this Feb 9, 2022
@bors bors bot closed this as completed in #1246 Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@thomaseizinger thomaseizinger

Labels
enhancement New feature or request productivity Tasks that help our productivity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enable more lints across the workspace get10101/itchysats
1 participant
@thomaseizinger