Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove explicit reference to TBL, Lab numbers from notebooks and function names #1

Open
lheagy opened this issue Dec 30, 2018 · 5 comments
Assignees

Comments

@lheagy
Copy link
Member

lheagy commented Dec 30, 2018

since these are used in courses beyond EOSC 350 at UBC, the code should not specifically reference "Lab" or "TBL" unless we are explicitly using data from a lab or TBL at UBC

@yangdikun
Copy link
Member

Agree. We need apps as general as possible.
Another issue to address is not to blend too many things in one notebook - one notebook only conveys one point.

@lheagy
Copy link
Member Author

lheagy commented Jan 10, 2019

Specifically, GPR needs to be updated. @dccowan: would you be willing to take an initial crack at this?

@yangdikun: would you be willing to go through the notebooks and see which other ones have language specific to assignments / labs in 350 and list those in this issue so that we can keep track of them?

@yangdikun
Copy link
Member

The following contains reference to UBC/TBL/Lab

GPR_Lab6_FitData
GPR_TBL4_DOI_Resolution
Mag_FitProfile (no specific mentioning of Lab or TBL, but uses magnetic data from UBC)

@lheagy
Copy link
Member Author

lheagy commented Jan 18, 2019

Thanks @yangdikun, I think we can update the 2 GPR notebooks fairly easily. The Mag one is a bit tougher - because we do want students to be working with the data they collected.

For this one, I think it is still appropriate to use those data, but we should have the data file be an input parameter to the setup. This way, if you were to run a similar experiment, you could load in your data. Alternatively, you can still use the UBC data. Would that be a suitable solution @yangdikun?

@yangdikun
Copy link
Member

The mag data are loaded using like this
fileName = 'http://github.com/geoscixyz/gpgLabs/raw/master/assets/Mag/data/Lab1_Wednesday_TA.csv'

Do you think students can replace it with a local data file name (suppose they run the notebooks on bliner)?

Keeping the UBC data is ok because it serves as a template.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants