Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs class copies all Tab props to li element, causes warning #94

Open
mgsouth opened this issue Jan 28, 2018 · 0 comments
Open

Tabs class copies all Tab props to li element, causes warning #94

mgsouth opened this issue Jan 28, 2018 · 0 comments

Comments

@mgsouth
Copy link
Contributor

mgsouth commented Jan 28, 2018 •
edited
Loading

When Tabs.js render() creates the

  • element for a tab, it copies all of the tab's props. One of them, "uncloseable" (renamed from "disableClose" in my PR) is a boolean. Copying this prop to
  • results in a react-dom warning that a "Received true for a non-boolean attribute uncloseable."

    		•
    @mgsouth mgsouth changed the title Tabs class copies all Tab props to li element, causes Development warning Tabs class copies all Tab props to li element, causeswarning Jan 28, 2018
    @mgsouth mgsouth changed the title Tabs class copies all Tab props to li element, causeswarning Tabs class copies all Tab props to li element, causes warning Jan 28, 2018
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    None yet
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @mgsouth