-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt Christmas dates with languages #700
Comments
Interesting, i didn't knew about this! This is a manual message posted every years. Not sure what to do here. And what about the new year? Chinese new year starts on Feb 1st ;) Thanks for bringing this to my attention. Let's keep it open - we'll come back to it "later" ;) |
I also not sure what to do, that's why I posted this :) BTW also in Montenegro Christmas is on 7th) |
Ethiopian new year is on the 11th of September ... |
Does some open data exists about all the Edit: https://github.com/azuyalabs/yasumi for example |
I've just got email from GK containing the news from 24.12 "Merry Christmas". While it's cool to see, I have to notice that at least in some languages it's not correct.
For example, in Russia Christmas is 7th of January. Thus, Russian text "С Рождеством Христовым .." on 24th of December looks suspicious :)
Not sure what should be the better approach here: copy the same message for 7th of Jan or split the languages and do not wish Merry Christmas on 24th to Russians but wish on 7th... And probably for other countries there might be similar inconsistencies...
The text was updated successfully, but these errors were encountered: