Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt Christmas dates with languages #700

Open
okainov opened this issue Dec 27, 2021 · 4 comments
Open

Adapt Christmas dates with languages #700

okainov opened this issue Dec 27, 2021 · 4 comments

Comments

@okainov
Copy link
Member

okainov commented Dec 27, 2021

I've just got email from GK containing the news from 24.12 "Merry Christmas". While it's cool to see, I have to notice that at least in some languages it's not correct.
For example, in Russia Christmas is 7th of January. Thus, Russian text "С Рождеством Христовым .." on 24th of December looks suspicious :)

Not sure what should be the better approach here: copy the same message for 7th of Jan or split the languages and do not wish Merry Christmas on 24th to Russians but wish on 7th... And probably for other countries there might be similar inconsistencies...

@kumy
Copy link
Member

kumy commented Dec 31, 2021

Interesting, i didn't knew about this! This is a manual message posted every years. Not sure what to do here. And what about the new year? Chinese new year starts on Feb 1st ;)

Thanks for bringing this to my attention. Let's keep it open - we'll come back to it "later" ;)

@okainov
Copy link
Member Author

okainov commented Dec 31, 2021

I also not sure what to do, that's why I posted this :)

BTW also in Montenegro Christmas is on 7th)

@GGGuerin
Copy link

GGGuerin commented Jan 4, 2022

Ethiopian new year is on the 11th of September ...
More and more complex this topic ;-)

@kumy
Copy link
Member

kumy commented Jan 4, 2022

Does some open data exists about all the new years / Christmas different schedule per country?

Edit: https://github.com/azuyalabs/yasumi for example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants