Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UK Regions #176

Open
origal opened this issue Jun 5, 2019 · 1 comment
Open

UK Regions #176

origal opened this issue Jun 5, 2019 · 1 comment

Comments

@origal
Copy link

origal commented Jun 5, 2019

Hi,

Trying to lookup any IP in England, I always get ENG as the region.
Looking at MaxMind's GeoLite2-City-Locations-en.csv I see that in fact all subdivision_1_iso_code in the UK is set to ENG, but there's another field subdivision_2_iso_code that provides a more detailed region code for England, for example OXF for Oxford.

Could we get region sub2 in the response of this module lookup method, if it exists?

Thanks

@ar2rsawseen
Copy link
Collaborator

Of course we could add that, and many other components too
But with each such component, memory footprint grows much larger, so the question is, what should be added and what should not :)

Will try to test eventually what is the memory difference and then we can decide more on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants