-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fails to retrieve digest from Red Hat registry #161
Comments
It seems that the RedHat registry does not add the header https://github.com/genuinetools/reg/blob/master/registry/digest.go#L38 |
Yes, I've noticed that also. I wonder how the docker cli is doing. It does display it upon pulling so does it need to pull the image to check the digest or is it figuring that out some other way?
Regards,Luiz
On Thursday, November 8, 2018, 8:09:21 AM EST, Darrian <[email protected]> wrote:
It seems that the RedHat registry does not add the header Docker-Content-Digest on the response when asking for a manifest which is what reg is checking.
https://github.com/genuinetools/reg/blob/master/registry/digest.go#L38
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
The digest is also in the manifest. I had a go at changing the // Digest returns the digest for an image.
func (r *Registry) Digest(image Image) (digest.Digest, error) {
if len(image.Digest) > 1 {
// return early if we already have an image digest.
return image.Digest, nil
}
mf, err := r.ManifestV2(image.Path, image.Reference())
if err != nil {
return "", err
}
return mf.Config.Digest, nil
} |
This is not the Digest but the Docker ID. |
See commands below (no credentials needed for that image):
$ reg digest registry.access.redhat.com/rhscl/mysql-57-rhel7
invalid checksum digest format
$ docker pull registry.access.redhat.com/rhscl/mysql-57-rhel7
Using default tag: latest
latest: Pulling from rhscl/mysql-57-rhel7
Digest: sha256:6652ef182f61bf1efa25ea101346d6bf72685ac897902a837cf73b200e3a5b2d
Status: Image is up to date for registry.access.redhat.com/rhscl/mysql-57-rhel7:latest
version tested: v0.15.8
environment: MacOS High Sierra 10.13.6
The text was updated successfully, but these errors were encountered: