Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minerva to handle “maximal-causal-chain-length” and “display-as-pathway-override” #448

Open
Tracked by #746
kltm opened this issue Jan 22, 2022 · 4 comments
Assignees

Comments

@kltm
Copy link
Member

kltm commented Jan 22, 2022

Update minerva to handle “maximal-causal-chain-length” and “display-as-pathway-override”, including returning them on results and automatically updating “maximal-causal-chain-length”.

Tagging @balhoff

@balhoff
Copy link
Member

balhoff commented Feb 16, 2022

Am I correct that the maximal-causal-chain-length of this graph would be 2, since activity 4 has no enabler defined?

flowchart LR
A1(activity 1) --enabled by--> G1(gene 1);
A2(activity 2) --enabled by--> G2(gene 2);
A3(activity 3) --enabled by--> G3(gene 3);
A1 --regulates--> A2;
A2 --causally upstream of--> A3;
A3 --positively regulates--> A4(activity 4);
Loading

cc @vanaukenk @ukemi @cmungall @sierra-moxon

@ukemi
Copy link

ukemi commented Feb 16, 2022

I've been making models with placeholder activities when I know an activity occurs, but I don't know exactly which gene product enables it. I think this would be useful to display and should be counted, but it's just my 2 cents.

@balhoff
Copy link
Member

balhoff commented Feb 16, 2022

Another question: should all the nodes in the chain being counted be molecular functions (vs. processes)?

@ukemi
Copy link

ukemi commented Feb 16, 2022

I would vote yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants