Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrofit all molecular function regulators to follow latest pattern #13492

Open
1 of 3 tasks
dosumis opened this issue May 12, 2017 · 12 comments
Open
1 of 3 tasks

Retrofit all molecular function regulators to follow latest pattern #13492

dosumis opened this issue May 12, 2017 · 12 comments

Comments

@dosumis
Copy link
Contributor

dosumis commented May 12, 2017

Needs to support keeping references. This should work, given pattern spec.

To be determined:

  • How do we flush and replace old terms?
  • Should we move this whole branch to autogeneration?

TODO:

  • Edit script so that tsv conforms to spec for dosdp-scala
  • Generate terms
  • ...

(Ticket split off from #12995) CC @cmungall @balhoff - This is a good branch for implementing generation with dosdp-scala. It'd be great if we could have this working before the Corvalis meeting.

@dosumis
Copy link
Contributor Author

dosumis commented May 26, 2017

cmungall added a commit to cmungall/go-ontology that referenced this issue May 26, 2017
@cmungall
Copy link
Member

Ignore the hash-mention above, wrong ticket

@dosumis
Copy link
Contributor Author

dosumis commented May 26, 2017

This partly works

dosdp-scala generate --obo-prefixes=true --template=design_patterns/validated_patterns/activator_activity.yaml --infile=pattern_implementation_tsv/activator_activity.tsv --outfile=activator_activity.ofn --ontology=../go-simple.obo

But only after changing IDs in pattern to OBO style to fit with --obo-prefixes (should be discussed).

BUG: def_dbxrefs end up like this:

GOC:BHF,GOC:dph,GOC:tb

image

Looks like string gets cast to a uniq'd list of characters.

But report here: INCATools/dosdp-tools#14

@balhoff
Copy link
Member

balhoff commented May 26, 2017

@dosumis
Copy link
Contributor Author

dosumis commented Jul 17, 2017

@pgaudet
Copy link
Contributor

pgaudet commented Apr 12, 2018

@balhoff Do you know what's the status on this one ?

Thanks, Pascale

@dosumis
Copy link
Contributor Author

dosumis commented Apr 12, 2018

It should be possible to run dosdp-tools with tsv + pattern doc to generate a set of terms following the patterns.

TSV is here: https://gist.github.com/dosumis/4d899727896367c9b432e733e120b675. Will need to be split into regulator, activator, inhibitor. Separate patterns for these are:

https://github.com/geneontology/go-ontology/blob/master/src/design_patterns/activator_activity.yaml
https://github.com/geneontology/go-ontology/blob/master/src/design_patterns/inhibitor_activity.yaml
https://github.com/geneontology/go-ontology/blob/master/src/design_patterns/regulator_activity.yaml

@pgaudet
Copy link
Contributor

pgaudet commented Apr 12, 2018

Hi @dosumis Thanks for your response ! This is a little cryptic to me - who might be able to do this ?

Thanks, Pascale

@dosumis
Copy link
Contributor Author

dosumis commented Apr 12, 2018

Just realised I already split out activator, inhibitor and regulator terms to separate TSVs already. I have moved the files into the design_patterns folder

dosdp_tools is here: https://github.com/INCATools/dosdp-tools

It's easy to install.

This command from the design_patterns folder generates an OWL file of regulator activity terms following the pattern:

dosdp-tools --obo-prefixes --ontology=../ontology/go-edit.obo --outfile=regulator_activity.owl --template=regulator_activity.yaml generate --infile=regulator_activity.tsv

This was all meant to have been hooked up to the INCA tools table editor as a replacement for TermGenie. I guess that still hasn't happened?

@dosumis
Copy link
Contributor Author

dosumis commented Apr 12, 2018

Looks like the TermGenie replacement plan was tantalisingly close: #13692

@balhoff
Copy link
Member

balhoff commented Apr 13, 2018

I'll need to have a conversation with @cmungall and maybe @dosumis to see how I can help here.

@pgaudet pgaudet assigned pgaudet and unassigned dosumis Feb 11, 2021
@pgaudet pgaudet removed their assignment Aug 24, 2022
@ValWood
Copy link
Contributor

ValWood commented Oct 25, 2024

@pgaudet is this one out of date?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants